fix: avoid compiler generating incorrect code#290
Merged
yyx990803 merged 1 commit intovuejs:masterfrom Oct 15, 2019
HcySunYang:fix-generate-wrong-code
Merged
fix: avoid compiler generating incorrect code#290yyx990803 merged 1 commit intovuejs:masterfrom HcySunYang:fix-generate-wrong-code
yyx990803 merged 1 commit intovuejs:masterfrom
HcySunYang:fix-generate-wrong-code
Conversation
Contributor
|
Shouldn't it throw or at least warn? Not sure how it works in 2.x tho |
Member
Author
|
In the 2.x version, the template below: <div>{{}}</div>The delimiters will be considered plain text. If the template is as follows: <div>{{ }}</div>Will generate empty text(''), but neither case throws an error or warn. |
Contributor
|
I see. Do i understand correctly it's a breaking change ( |
Member
|
I'd say the current 2.x behavior is a bug. |
Contributor
|
Hey @HcySunYang, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that empty interpolation will be compiled into
toString(_ctx.).E.g:
{{}}Generated: