chore(release): make release publishing resumable#14953
Merged
Conversation
📝 WalkthroughWalkthroughThe release script now discovers packages by reading each ChangesRegistry-aware publishing and package ordering
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/release.js (1)
481-485: 💤 Low valueInconsistent color for the same outcome.
When a package is skipped due to already being published, line 455 uses yellow (
pico.yellow) for the pre-check case, but line 483 uses red (pico.red) for the publish-error case. Both represent the same semantic outcome (package was skipped because it already exists). Consider using consistent coloring.Suggested fix for consistency
} catch (/** `@type` {any} */ e) { if (e.message?.match(/previously published/)) { const pkgVersion = `${packageName}@${version}` - console.log(pico.red(`Skipping already published: ${pkgVersion}`)) + console.log(pico.yellow(`Skipping already published: ${pkgVersion}`)) alreadyPublishedPackages.push(pkgVersion) } else {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/release.js` around lines 481 - 485, The log color for skipped packages is inconsistent: the pre-check uses pico.yellow while the publish-error path uses pico.red; update the publish-error branch inside the error handler that pushes into alreadyPublishedPackages (where pkgVersion is built from packageName and version) to use the same pico color as the pre-check (use pico.yellow or choose a single color and apply it to both places) so both code paths print the identical colored message for the same "already published" outcome.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/release.js`:
- Around line 481-485: The log color for skipped packages is inconsistent: the
pre-check uses pico.yellow while the publish-error path uses pico.red; update
the publish-error branch inside the error handler that pushes into
alreadyPublishedPackages (where pkgVersion is built from packageName and
version) to use the same pico color as the pre-check (use pico.yellow or choose
a single color and apply it to both places) so both code paths print the
identical colored message for the same "already published" outcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit