Skip to content

fix(compiler-vapor): prevent caching variables in function expression#13244

Merged
edison1105 merged 10 commits intovuejs:vaporfrom
zhiyuanzmj:fix-cache-variable
Jun 18, 2025
Merged

fix(compiler-vapor): prevent caching variables in function expression#13244
edison1105 merged 10 commits intovuejs:vaporfrom
zhiyuanzmj:fix-cache-variable

Conversation

@zhiyuanzmj
Copy link
Copy Markdown
Member

@zhiyuanzmj zhiyuanzmj commented Apr 26, 2025 •
edited
Loading 

 const { ir, code } = compileWithTransformRef(
    `<div :ref="bar => foo = bar" />`,
    { inline: true },
  )
  expect(code).toMatchInlineSnapshot(`
    "
      const _setTemplateRef = _createTemplateRefSetter()
      const n0 = t0()
      let r0
      _renderEffect(() => {
        const _bar = bar 
     // ^^^^^^^^^^^^^^^^
        r0 = _setTemplateRef(n0, bar => foo = bar, r0)
      })
      return n0
    "
  `)

const _bar = bar shouldn't be generated

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 26, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 26, 2025 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit d884b02
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/68200804306d84000810cf69
😎 Deploy Preview https://deploy-preview-13244--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 26, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13244

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13244

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13244

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13244

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13244

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13244

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13244

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13244

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13244

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13244

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13244

vue

npm i https://pkg.pr.new/vue@13244

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13244

commit: d884b02

@edison1105 edison1105 added the scope: vapor related to vapor mode label Apr 29, 2025
@zhiyuanzmj zhiyuanzmj mentioned this pull request May 17, 2025
Merged
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Jun 18, 2025
@edison1105 edison1105 merged commit 99482a4 into vuejs:vapor Jun 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready to merge The PR is ready to be merged. scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhiyuanzmj @edison1105