Skip to content

fix(compiler-vapor): preserve comment-only default slots while ignoring mixed slot comments#14604

Merged
edison1105 merged 2 commits intominorfrom
edison/fix/vaporSlotComment
Mar 19, 2026
Merged

fix(compiler-vapor): preserve comment-only default slots while ignoring mixed slot comments#14604
edison1105 merged 2 commits intominorfrom
edison/fix/vaporSlotComment

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Mar 19, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved comment node handling within component slots to ensure proper compilation when components contain comment-only children or mixed slot content with comments.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 19, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1fcb2028-f811-4b60-a49b-fc387b3eae90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch edison/fix/vaporSlotComment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 111 kB 41.9 kB 37.5 kB
vue.global.prod.js 170 kB 61.7 kB 55 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 50.6 kB 19.8 kB 18 kB
createApp 59.6 kB 23.1 kB 21 kB
createApp + vaporInteropPlugin 84.9 kB 31.3 kB 28.4 kB
createVaporApp 28.7 kB 11.1 kB 10.2 kB
createSSRApp 63.9 kB 24.8 kB 22.5 kB
createVaporSSRApp 31.9 kB 12.3 kB 11.3 kB
defineCustomElement 66.2 kB 25.1 kB 22.8 kB
defineVaporCustomElement 39.3 kB 14.5 kB 13.3 kB
overall 74.5 kB 28.4 kB 25.8 kB

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 19, 2026 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14604

npm i https://pkg.pr.new/@vue/compiler-core@14604

yarn add https://pkg.pr.new/@vue/compiler-core@14604.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14604

npm i https://pkg.pr.new/@vue/compiler-dom@14604

yarn add https://pkg.pr.new/@vue/compiler-dom@14604.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14604

npm i https://pkg.pr.new/@vue/compiler-sfc@14604

yarn add https://pkg.pr.new/@vue/compiler-sfc@14604.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14604

npm i https://pkg.pr.new/@vue/compiler-ssr@14604

yarn add https://pkg.pr.new/@vue/compiler-ssr@14604.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14604

npm i https://pkg.pr.new/@vue/compiler-vapor@14604

yarn add https://pkg.pr.new/@vue/compiler-vapor@14604.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14604

npm i https://pkg.pr.new/@vue/reactivity@14604

yarn add https://pkg.pr.new/@vue/reactivity@14604.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14604

npm i https://pkg.pr.new/@vue/runtime-core@14604

yarn add https://pkg.pr.new/@vue/runtime-core@14604.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14604

npm i https://pkg.pr.new/@vue/runtime-dom@14604

yarn add https://pkg.pr.new/@vue/runtime-dom@14604.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14604

npm i https://pkg.pr.new/@vue/runtime-vapor@14604

yarn add https://pkg.pr.new/@vue/runtime-vapor@14604.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14604

npm i https://pkg.pr.new/@vue/server-renderer@14604

yarn add https://pkg.pr.new/@vue/server-renderer@14604.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14604

npm i https://pkg.pr.new/@vue/shared@14604

yarn add https://pkg.pr.new/@vue/shared@14604.tgz

vue

pnpm add https://pkg.pr.new/vue@14604

npm i https://pkg.pr.new/vue@14604

yarn add https://pkg.pr.new/vue@14604.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14604

npm i https://pkg.pr.new/@vue/compat@14604

yarn add https://pkg.pr.new/@vue/compat@14604.tgz

commit: a4c2443

@edison1105 edison1105 merged commit c245dae into minor Mar 19, 2026
16 of 17 checks passed
@edison1105 edison1105 deleted the edison/fix/vaporSlotComment branch March 19, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edison1105