Skip to content

fix(compiler-vapor): ignore comments when checking extraneous default slot children#14601

Merged
edison1105 merged 4 commits intovuejs:minorfrom
jackma9604:fix/vapor-slot
Mar 19, 2026
Merged

fix(compiler-vapor): ignore comments when checking extraneous default slot children#14601
edison1105 merged 4 commits intovuejs:minorfrom
jackma9604:fix/vapor-slot

Conversation

@jackma9604
Copy link
Copy Markdown

@jackma9604 jackma9604 commented Mar 17, 2026

Problem Description

Annotating a node in a slot is considered as the default slot node

Vue Version

3.6.0-beta.8

Link to minimal reproduction

Playground

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c2321bf8-87cc-450b-840f-9677a48ece21

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 17, 2026 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14601

npm i https://pkg.pr.new/@vue/compiler-core@14601

yarn add https://pkg.pr.new/@vue/compiler-core@14601.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14601

npm i https://pkg.pr.new/@vue/compiler-dom@14601

yarn add https://pkg.pr.new/@vue/compiler-dom@14601.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14601

npm i https://pkg.pr.new/@vue/compiler-sfc@14601

yarn add https://pkg.pr.new/@vue/compiler-sfc@14601.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14601

npm i https://pkg.pr.new/@vue/compiler-ssr@14601

yarn add https://pkg.pr.new/@vue/compiler-ssr@14601.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14601

npm i https://pkg.pr.new/@vue/compiler-vapor@14601

yarn add https://pkg.pr.new/@vue/compiler-vapor@14601.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14601

npm i https://pkg.pr.new/@vue/reactivity@14601

yarn add https://pkg.pr.new/@vue/reactivity@14601.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14601

npm i https://pkg.pr.new/@vue/runtime-core@14601

yarn add https://pkg.pr.new/@vue/runtime-core@14601.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14601

npm i https://pkg.pr.new/@vue/runtime-dom@14601

yarn add https://pkg.pr.new/@vue/runtime-dom@14601.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14601

npm i https://pkg.pr.new/@vue/runtime-vapor@14601

yarn add https://pkg.pr.new/@vue/runtime-vapor@14601.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14601

npm i https://pkg.pr.new/@vue/server-renderer@14601

yarn add https://pkg.pr.new/@vue/server-renderer@14601.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14601

npm i https://pkg.pr.new/@vue/shared@14601

yarn add https://pkg.pr.new/@vue/shared@14601.tgz

vue

pnpm add https://pkg.pr.new/vue@14601

npm i https://pkg.pr.new/vue@14601

yarn add https://pkg.pr.new/vue@14601.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14601

npm i https://pkg.pr.new/@vue/compat@14601

yarn add https://pkg.pr.new/@vue/compat@14601.tgz

commit: 0c4e6f4

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 111 kB 41.9 kB 37.5 kB
vue.global.prod.js 170 kB 61.7 kB 55 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 50.6 kB 19.8 kB 18 kB
createApp 59.6 kB 23.1 kB 21 kB
createApp + vaporInteropPlugin 84.9 kB 31.3 kB 28.4 kB
createVaporApp 28.7 kB 11.1 kB 10.2 kB
createSSRApp 63.9 kB 24.8 kB 22.5 kB
createVaporSSRApp 31.9 kB 12.3 kB 11.3 kB
defineCustomElement 66.2 kB 25.1 kB 22.8 kB
defineVaporCustomElement 39.3 kB 14.5 kB 13.3 kB
overall 74.5 kB 28.4 kB 25.8 kB

@edison1105 edison1105 changed the title fix(compiler-vapor): In slot, comments should not be regarded as default child nodes fix(compiler-vapor): ignore comments when checking extraneous default slot children Mar 19, 2026
@edison1105 edison1105 merged commit 5af41dd into vuejs:minor Mar 19, 2026
12 of 14 checks passed
@jackma9604 jackma9604 deleted the fix/vapor-slot branch March 19, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackma9604 @edison1105