Skip to content

fix(runtime-vapor): ensure vapor slot unmounting removes vnode slot content#14520

Merged
edison1105 merged 1 commit intominorfrom
bugfix/vapor-interop-slot-unmount-cleanup
Mar 5, 2026
Merged

fix(runtime-vapor): ensure vapor slot unmounting removes vnode slot content#14520
edison1105 merged 1 commit intominorfrom
bugfix/vapor-interop-slot-unmount-cleanup

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Mar 5, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 5, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 95b8be97-7fe1-4dfd-9e61-dfc62a0428de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/vapor-interop-slot-unmount-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

@edison1105 edison1105 added scope: vapor related to vapor mode interop vdom / vapor interop labels Mar 5, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 5, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14520

npm i https://pkg.pr.new/@vue/compiler-core@14520

yarn add https://pkg.pr.new/@vue/compiler-core@14520.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14520

npm i https://pkg.pr.new/@vue/compiler-dom@14520

yarn add https://pkg.pr.new/@vue/compiler-dom@14520.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14520

npm i https://pkg.pr.new/@vue/compiler-sfc@14520

yarn add https://pkg.pr.new/@vue/compiler-sfc@14520.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14520

npm i https://pkg.pr.new/@vue/compiler-ssr@14520

yarn add https://pkg.pr.new/@vue/compiler-ssr@14520.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14520

npm i https://pkg.pr.new/@vue/compiler-vapor@14520

yarn add https://pkg.pr.new/@vue/compiler-vapor@14520.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14520

npm i https://pkg.pr.new/@vue/reactivity@14520

yarn add https://pkg.pr.new/@vue/reactivity@14520.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14520

npm i https://pkg.pr.new/@vue/runtime-core@14520

yarn add https://pkg.pr.new/@vue/runtime-core@14520.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14520

npm i https://pkg.pr.new/@vue/runtime-dom@14520

yarn add https://pkg.pr.new/@vue/runtime-dom@14520.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14520

npm i https://pkg.pr.new/@vue/runtime-vapor@14520

yarn add https://pkg.pr.new/@vue/runtime-vapor@14520.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14520

npm i https://pkg.pr.new/@vue/server-renderer@14520

yarn add https://pkg.pr.new/@vue/server-renderer@14520.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14520

npm i https://pkg.pr.new/@vue/shared@14520

yarn add https://pkg.pr.new/@vue/shared@14520.tgz

vue

pnpm add https://pkg.pr.new/vue@14520

npm i https://pkg.pr.new/vue@14520

yarn add https://pkg.pr.new/vue@14520.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14520

npm i https://pkg.pr.new/@vue/compat@14520

yarn add https://pkg.pr.new/@vue/compat@14520.tgz

commit: 48c0461

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 110 kB 41.6 kB 37.3 kB
vue.global.prod.js 169 kB 61.4 kB 54.7 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 50.3 kB 19.7 kB 18 kB
createApp 59.3 kB 23 kB 20.9 kB
createApp + vaporInteropPlugin 83 kB (+3 B) 30.8 kB (-4 B) 27.9 kB (-7 B)
createVaporApp 28.6 kB 11.1 kB 10.2 kB
createSSRApp 63.5 kB 24.7 kB 22.4 kB
createVaporSSRApp 32.1 kB 12.4 kB 11.4 kB
defineCustomElement 65.3 kB 24.8 kB 22.5 kB
defineVaporCustomElement 38.9 kB 14.4 kB 13.2 kB
overall 74.2 kB 28.3 kB 25.7 kB

@edison1105 edison1105 merged commit eff4cab into minor Mar 5, 2026
17 checks passed
@edison1105 edison1105 deleted the bugfix/vapor-interop-slot-unmount-cleanup branch March 5, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

interop vdom / vapor interop scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edison1105