Skip to content

fix(Teleport): modifying non-essential attributes does not require up…#14438

Merged
edison1105 merged 1 commit intovuejs:minorfrom
jackma9604:fix/Teleport
Feb 10, 2026
Merged

fix(Teleport): modifying non-essential attributes does not require up…#14438
edison1105 merged 1 commit intovuejs:minorfrom
jackma9604:fix/Teleport

Conversation

@jackma9604
Copy link
Copy Markdown

@jackma9604 jackma9604 commented Feb 10, 2026

Problem Description

In Teleport, modifying non-critical attributes will still update the animation effects.

Version

v3.6.0-beta.5

Steps to reproduce

Click 'change-defer' button

Link to minimal reproduction

Playground

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 10, 2026 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14438

npm i https://pkg.pr.new/@vue/compiler-core@14438

yarn add https://pkg.pr.new/@vue/compiler-core@14438.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14438

npm i https://pkg.pr.new/@vue/compiler-dom@14438

yarn add https://pkg.pr.new/@vue/compiler-dom@14438.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14438

npm i https://pkg.pr.new/@vue/compiler-sfc@14438

yarn add https://pkg.pr.new/@vue/compiler-sfc@14438.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14438

npm i https://pkg.pr.new/@vue/compiler-ssr@14438

yarn add https://pkg.pr.new/@vue/compiler-ssr@14438.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14438

npm i https://pkg.pr.new/@vue/compiler-vapor@14438

yarn add https://pkg.pr.new/@vue/compiler-vapor@14438.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14438

npm i https://pkg.pr.new/@vue/reactivity@14438

yarn add https://pkg.pr.new/@vue/reactivity@14438.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14438

npm i https://pkg.pr.new/@vue/runtime-core@14438

yarn add https://pkg.pr.new/@vue/runtime-core@14438.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14438

npm i https://pkg.pr.new/@vue/runtime-dom@14438

yarn add https://pkg.pr.new/@vue/runtime-dom@14438.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14438

npm i https://pkg.pr.new/@vue/runtime-vapor@14438

yarn add https://pkg.pr.new/@vue/runtime-vapor@14438.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14438

npm i https://pkg.pr.new/@vue/server-renderer@14438

yarn add https://pkg.pr.new/@vue/server-renderer@14438.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14438

npm i https://pkg.pr.new/@vue/shared@14438

yarn add https://pkg.pr.new/@vue/shared@14438.tgz

vue

pnpm add https://pkg.pr.new/vue@14438

npm i https://pkg.pr.new/vue@14438

yarn add https://pkg.pr.new/vue@14438.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14438

npm i https://pkg.pr.new/@vue/compat@14438

yarn add https://pkg.pr.new/@vue/compat@14438.tgz

commit: 3bda5e0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 110 kB 41.6 kB 37.3 kB
vue.global.prod.js 169 kB 61.4 kB 54.8 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 50.3 kB 19.7 kB 18 kB
createApp 59.3 kB 23 kB 20.9 kB
createApp + vaporInteropPlugin 82.3 kB 30.5 kB 27.6 kB
createVaporApp 28.6 kB 11.1 kB 10.2 kB
createSSRApp 63.5 kB 24.7 kB 22.4 kB
createVaporSSRApp 32 kB 12.4 kB 11.3 kB
defineCustomElement 65.3 kB 24.8 kB 22.5 kB
defineVaporCustomElement 38.9 kB 14.4 kB 13.2 kB
overall 74.1 kB 28.3 kB 25.7 kB

edison1105
edison1105 reviewed Feb 10, 2026
View reviewed changes
packages/runtime-vapor/__tests__/components/Teleport.spec.ts Outdated

disabled.value = true
await nextTick()
expect(beforeEnter).toHaveBeenCalledTimes(1)
Copy link
Copy Markdown
Member

@edison1105 edison1105 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. According to your reproduction, beforeEnter should not be executed at all.

Copy link
Copy Markdown
Author

@jackma9604 jackma9604 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When disabled turns from false to true, the nodes will change their positions. I think this is correct.

Copy link
Copy Markdown
Member

@edison1105 edison1105 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not. Only actual mount/unmount will trigger enter/leave animations. This aligns with vdom teleport behavior.

Thanks for the PR. I've made a new PR address for this. see #14440

Copy link
Copy Markdown
Author

@jackma9604 jackma9604 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Copy link
Copy Markdown
Author

@jackma9604 jackma9604 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If disabled is already true, modifying the to attribute does not need to trigger the handlePropsUpdate method

if (wasDisabled !== this.isDisabled || prevTo !== this.resolvedProps.to) {
     this.handlePropsUpdate()
}

Copy link
Copy Markdown
Member

@edison1105 edison1105 Feb 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhh~
should be

      if (
        wasDisabled !== this.isDisabled ||
        (!this.isDisabled && prevTo !== this.resolvedProps.to)
      ) {
        this.handlePropsUpdate()
      }

Could you please rebase your PR and include this changes?

edison1105 added a commit that referenced this pull request Feb 10, 2026
@edison1105
fix(teleport): optimize transition handling and prevent unnecessary u…
90ea8ce 
…pdates (#14440)

close #14438
@jackma9604 jackma9604 closed this Feb 10, 2026
@jackma9604 jackma9604 reopened this Feb 10, 2026
@edison1105 edison1105 merged commit 102b32b into vuejs:minor Feb 10, 2026
14 of 15 checks passed
@jackma9604 jackma9604 deleted the fix/Teleport branch February 11, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackma9604 @edison1105