Skip to content

fix(runtime-vapor): isolate slotProps per fragment in v-for slots#14406

Merged
edison1105 merged 4 commits intominorfrom
edison/fix/14397
Feb 4, 2026
Merged

fix(runtime-vapor): isolate slotProps per fragment in v-for slots#14406
edison1105 merged 4 commits intominorfrom
edison/fix/14397

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Feb 3, 2026 •
edited by coderabbitai bot
Loading

close #14397

Summary by CodeRabbit

  • Bug Fixes
    • Fixed selector reactivity to correctly update when list changes occur after value updates.
    • Fixed slot prop isolation in v-for loops to prevent properties from interfering across list items.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 3, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • ✅ Full review completed - (🔄 Check again to review again)
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/14397

Comment @coderabbitai help to get the list of available commands and usage tips.

@edison1105 edison1105 linked an issue Feb 3, 2026 that may be closed by this pull request
[VAPOR] Issue with slot rendering/scoped slot props #14397
Closed
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 3, 2026 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14406

npm i https://pkg.pr.new/@vue/compiler-core@14406

yarn add https://pkg.pr.new/@vue/compiler-core@14406.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14406

npm i https://pkg.pr.new/@vue/compiler-dom@14406

yarn add https://pkg.pr.new/@vue/compiler-dom@14406.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14406

npm i https://pkg.pr.new/@vue/compiler-sfc@14406

yarn add https://pkg.pr.new/@vue/compiler-sfc@14406.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14406

npm i https://pkg.pr.new/@vue/compiler-ssr@14406

yarn add https://pkg.pr.new/@vue/compiler-ssr@14406.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14406

npm i https://pkg.pr.new/@vue/compiler-vapor@14406

yarn add https://pkg.pr.new/@vue/compiler-vapor@14406.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14406

npm i https://pkg.pr.new/@vue/reactivity@14406

yarn add https://pkg.pr.new/@vue/reactivity@14406.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14406

npm i https://pkg.pr.new/@vue/runtime-core@14406

yarn add https://pkg.pr.new/@vue/runtime-core@14406.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14406

npm i https://pkg.pr.new/@vue/runtime-dom@14406

yarn add https://pkg.pr.new/@vue/runtime-dom@14406.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14406

npm i https://pkg.pr.new/@vue/runtime-vapor@14406

yarn add https://pkg.pr.new/@vue/runtime-vapor@14406.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14406

npm i https://pkg.pr.new/@vue/server-renderer@14406

yarn add https://pkg.pr.new/@vue/server-renderer@14406.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14406

npm i https://pkg.pr.new/@vue/shared@14406

yarn add https://pkg.pr.new/@vue/shared@14406.tgz

vue

pnpm add https://pkg.pr.new/vue@14406

npm i https://pkg.pr.new/vue@14406

yarn add https://pkg.pr.new/vue@14406.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14406

npm i https://pkg.pr.new/@vue/compat@14406

yarn add https://pkg.pr.new/@vue/compat@14406.tgz

commit: 2d680fb

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 109 kB 41.4 kB 37.2 kB
vue.global.prod.js 169 kB 61.2 kB 54.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.5 kB 19.4 kB 17.7 kB
createApp 58.5 kB 22.7 kB 20.7 kB
createApp + vaporInteropPlugin 81.5 kB 30.3 kB 27.4 kB
createVaporApp 28.7 kB 11.1 kB 10.2 kB
createSSRApp 62.8 kB 24.4 kB 22.2 kB
createVaporSSRApp 32.1 kB 12.4 kB 11.4 kB
defineCustomElement 64.5 kB 24.6 kB 22.3 kB
defineVaporCustomElement 39 kB 14.4 kB 13.2 kB
overall 73.3 kB 28 kB 25.4 kB

coderabbitai[bot]
coderabbitai bot reviewed Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/runtime-vapor/src/apiCreateFor.ts (1)

519-535: ⚠️ Potential issue | 🟠 Major

Update activeKey when applying deferred selector changes.

activeKey stays at its initial value, so register()/deregister() can keep treating the old key as active and stale opers may continue firing after list changes. Set activeKey = newValue inside the post-flush callback before resolving activeOpers.

🛠️ Proposed fix 
 queuePostFlushCb(() => {
+  activeKey = newValue
   activeOpers = operMap.get(newValue)
   if (activeOpers !== undefined) {
     for (const oper of activeOpers) {
       oper()
     }
   }
 })

@edison1105 edison1105 added the scope: vapor related to vapor mode label Feb 3, 2026
@edison1105 edison1105 merged commit 9db9f1e into minor Feb 4, 2026
17 checks passed
@edison1105 edison1105 deleted the edison/fix/14397 branch February 4, 2026 08:07
@edison1105 edison1105 mentioned this pull request Feb 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[VAPOR] Issue with slot rendering/scoped slot props

1 participant

@edison1105