Skip to content

fix(compiler-vapor): handle invalid table nesting with dynamic child#14394

Merged
edison1105 merged 3 commits intovuejs:minorfrom
jackma9604:fix/14392
Feb 3, 2026
Merged

fix(compiler-vapor): handle invalid table nesting with dynamic child#14394
edison1105 merged 3 commits intovuejs:minorfrom
jackma9604:fix/14392

Conversation

@jackma9604
Copy link
Copy Markdown

@jackma9604 jackma9604 commented Feb 2, 2026 •
edited by coderabbitai bot
Loading

fix: #14392

Summary by CodeRabbit

  • Tests

    • Added test coverage for invalid table nesting scenarios with dynamic children

  • Refactor

    • Reordered element transformation pipeline for improved processing sequence
    • Optimized template generation for child elements with template directives to reduce redundant processing

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 2, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • ✅ Full review completed - (🔄 Check again to review again)
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 2, 2026 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14394

npm i https://pkg.pr.new/@vue/compiler-core@14394

yarn add https://pkg.pr.new/@vue/compiler-core@14394.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14394

npm i https://pkg.pr.new/@vue/compiler-dom@14394

yarn add https://pkg.pr.new/@vue/compiler-dom@14394.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14394

npm i https://pkg.pr.new/@vue/compiler-sfc@14394

yarn add https://pkg.pr.new/@vue/compiler-sfc@14394.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14394

npm i https://pkg.pr.new/@vue/compiler-ssr@14394

yarn add https://pkg.pr.new/@vue/compiler-ssr@14394.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14394

npm i https://pkg.pr.new/@vue/compiler-vapor@14394

yarn add https://pkg.pr.new/@vue/compiler-vapor@14394.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14394

npm i https://pkg.pr.new/@vue/reactivity@14394

yarn add https://pkg.pr.new/@vue/reactivity@14394.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14394

npm i https://pkg.pr.new/@vue/runtime-core@14394

yarn add https://pkg.pr.new/@vue/runtime-core@14394.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14394

npm i https://pkg.pr.new/@vue/runtime-dom@14394

yarn add https://pkg.pr.new/@vue/runtime-dom@14394.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14394

npm i https://pkg.pr.new/@vue/runtime-vapor@14394

yarn add https://pkg.pr.new/@vue/runtime-vapor@14394.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14394

npm i https://pkg.pr.new/@vue/server-renderer@14394

yarn add https://pkg.pr.new/@vue/server-renderer@14394.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14394

npm i https://pkg.pr.new/@vue/shared@14394

yarn add https://pkg.pr.new/@vue/shared@14394.tgz

vue

pnpm add https://pkg.pr.new/vue@14394

npm i https://pkg.pr.new/vue@14394

yarn add https://pkg.pr.new/vue@14394.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14394

npm i https://pkg.pr.new/@vue/compat@14394

yarn add https://pkg.pr.new/@vue/compat@14394.tgz

commit: 60db345

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 2, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 109 kB 41.4 kB 37.2 kB
vue.global.prod.js 169 kB 61.2 kB 54.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.5 kB 19.4 kB 17.7 kB
createApp 58.5 kB 22.7 kB 20.7 kB
createApp + vaporInteropPlugin 80.5 kB 29.9 kB 27.1 kB
createVaporApp 29.3 kB 11.3 kB 10.4 kB
createSSRApp 62.8 kB 24.4 kB 22.2 kB
createVaporSSRApp 32.7 kB 12.6 kB 11.5 kB
defineCustomElement 64.5 kB 24.6 kB 22.3 kB
defineVaporCustomElement 39.5 kB 14.6 kB 13.4 kB
overall 73.3 kB 28 kB 25.4 kB

@edison1105 edison1105 changed the title fix(compiler-vapor): A compilation error occurs when an element canno… fix(compiler-vapor): handle invalid table nesting with dynamic child Feb 3, 2026
@edison1105
Copy link
Copy Markdown
Member

edison1105 commented Feb 3, 2026

Thanks for the PR, but the changes are not correct.
I've updated the code to make all tests pass. see 60db345

@edison1105 edison1105 added the scope: vapor related to vapor mode label Feb 3, 2026
@edison1105 edison1105 linked an issue Feb 3, 2026 that may be closed by this pull request
[Vapor]: A compilation error occurs when an element cannot be used as a direct child #14392
Closed
@edison1105 edison1105 merged commit cd00cb8 into vuejs:minor Feb 3, 2026
15 checks passed
@edison1105 edison1105 mentioned this pull request Feb 3, 2026
Closed
@jackma9604 jackma9604 deleted the fix/14392 branch February 3, 2026 02:00
zhiyuanzmj added a commit to vuejs/vue-jsx-vapor that referenced this pull request Feb 3, 2026
@zhiyuanzmj
fix(compiler/vapor): handle invalid table nesting with dynamic child
712ec26 
Copied from vuejs/core#14394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Vapor]: A compilation error occurs when an element cannot be used as a direct child

2 participants

@jackma9604 @edison1105