Skip to content

fix(Transition): fix VaporTransition animation#14368

Closed
jackma9604 wants to merge 1 commit intovuejs:minorfrom
jackma9604:fix/VaporTransition
Closed

fix(Transition): fix VaporTransition animation#14368
jackma9604 wants to merge 1 commit intovuejs:minorfrom
jackma9604:fix/VaporTransition

Conversation

@jackma9604
Copy link
Copy Markdown

@jackma9604 jackma9604 commented Jan 28, 2026 •
edited
Loading

Problem Description

The vapor mode cannot transition normally!

Root Cause

In v-if, the element is considered as the same one

Vue Version

3.6.0-beta.4

Steps to reproduce

Click the button in the demo

Link to minimal reproduction

  1. This element has no exit animation, but this is normal in version 3.5.x
    v3.6.0-beta.4 play
    v3.5.27 play

  2. When the addition mode is set to out-in/in-out, an error is printed on the console. (Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.)
    play

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 28, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.5 kB
runtime-dom.global.prod.js 109 kB 41.3 kB 37.1 kB
vue.global.prod.js 169 kB 61.2 kB 54.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.5 kB 19.4 kB 17.7 kB
createApp 58.5 kB 22.7 kB 20.7 kB
createApp + vaporInteropPlugin 80.5 kB 29.9 kB 27.1 kB
createVaporApp 29.3 kB 11.3 kB 10.4 kB
createSSRApp 62.8 kB 24.4 kB 22.2 kB
createVaporSSRApp 32.7 kB 12.6 kB 11.5 kB
defineCustomElement 64.5 kB 24.6 kB 22.3 kB
defineVaporCustomElement 39.6 kB 14.6 kB 13.4 kB
overall 73.3 kB 28 kB 25.4 kB

@edison1105
Copy link
Copy Markdown
Member

edison1105 commented Jan 29, 2026

Thank you for your contribution. First, you identified the issue and provided a fix. However, this fix has some problems.

  • The key should only be added to the DynamicFragment when the parent node is VaporTransition.
  • We cannot use the render function as a key, as it will eventually be stored on node.$key. This carries certain risks.

I have made a fix to avoid the issues mentioned above. See #14374.

edison1105 added a commit that referenced this pull request Jan 29, 2026
@edison1105
fix(transition): add key for transition if-branches (#14374)
e08308e 
close #14368
@edison1105 edison1105 closed this Jan 29, 2026
@jackma9604 jackma9604 deleted the fix/VaporTransition branch January 29, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackma9604 @edison1105