Skip to content

fix(vapor): properly move vapor component / slot#14363

Merged
edison1105 merged 2 commits intovuejs:minorfrom
jackma9604:fix/MoveFn
Jan 28, 2026
Merged

fix(vapor): properly move vapor component / slot#14363
edison1105 merged 2 commits intovuejs:minorfrom
jackma9604:fix/MoveFn

Conversation

@jackma9604
Copy link
Copy Markdown

Problem Description

When the sub-component is vdom, the vapor slot cannot be removed in keepalive.

Root Cause

MoveFn ignores vapor block.

Version

3.6.0-beta.4

Validation

Playground

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 27, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.5 kB 30 kB 26.5 kB
runtime-dom.global.prod.js 108 kB (+24 B) 40.7 kB (-2 B) 36.6 kB (-26 B)
vue.global.prod.js 167 kB (+24 B) 60.8 kB (-2 B) 54.1 kB (-100 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.3 kB (+24 B) 18.9 kB (-2 B) 17.3 kB (-3 B)
createApp 57.3 kB (+24 B) 22 kB 20.1 kB (+6 B)
createApp + vaporInteropPlugin 78.5 kB (+30 B) 29 kB (+7 B) 26.4 kB (+33 B)
createVaporApp 27.9 kB 10.7 kB 9.84 kB
createSSRApp 61.6 kB (+24 B) 23.8 kB 21.7 kB (+13 B)
defineCustomElement 63.4 kB (+24 B) 23.9 kB (-1 B) 21.8 kB (-5 B)
overall 72.1 kB (+24 B) 27.3 kB (+1 B) 24.9 kB (+53 B)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jan 27, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14363
npm i https://pkg.pr.new/@vue/compiler-core@14363
yarn add https://pkg.pr.new/@vue/compiler-core@14363.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14363
npm i https://pkg.pr.new/@vue/compiler-dom@14363
yarn add https://pkg.pr.new/@vue/compiler-dom@14363.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14363
npm i https://pkg.pr.new/@vue/compiler-sfc@14363
yarn add https://pkg.pr.new/@vue/compiler-sfc@14363.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14363
npm i https://pkg.pr.new/@vue/compiler-ssr@14363
yarn add https://pkg.pr.new/@vue/compiler-ssr@14363.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14363
npm i https://pkg.pr.new/@vue/compiler-vapor@14363
yarn add https://pkg.pr.new/@vue/compiler-vapor@14363.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14363
npm i https://pkg.pr.new/@vue/reactivity@14363
yarn add https://pkg.pr.new/@vue/reactivity@14363.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14363
npm i https://pkg.pr.new/@vue/runtime-core@14363
yarn add https://pkg.pr.new/@vue/runtime-core@14363.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14363
npm i https://pkg.pr.new/@vue/runtime-dom@14363
yarn add https://pkg.pr.new/@vue/runtime-dom@14363.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14363
npm i https://pkg.pr.new/@vue/runtime-vapor@14363
yarn add https://pkg.pr.new/@vue/runtime-vapor@14363.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14363
npm i https://pkg.pr.new/@vue/server-renderer@14363
yarn add https://pkg.pr.new/@vue/server-renderer@14363.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14363
npm i https://pkg.pr.new/@vue/shared@14363
yarn add https://pkg.pr.new/@vue/shared@14363.tgz

vue

pnpm add https://pkg.pr.new/vue@14363
npm i https://pkg.pr.new/vue@14363
yarn add https://pkg.pr.new/vue@14363.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14363
npm i https://pkg.pr.new/@vue/compat@14363
yarn add https://pkg.pr.new/@vue/compat@14363.tgz

commit: 2d1eb9d

@edison1105 edison1105 added wait changes scope: vapor related to vapor mode interop vdom / vapor interop labels Jan 27, 2026
@edison1105 edison1105 changed the title fix(runtime-code): MoveFn is compatible with vapor block fix(vapor): properly move vapor component / slot Jan 27, 2026
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Jan 27, 2026
@edison1105 edison1105 moved this to Vapor in Next Minor Jan 27, 2026
@edison1105 edison1105 merged commit b0c04eb into vuejs:minor Jan 28, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from Vapor to Done in Next Minor Jan 28, 2026
@jackma9604 jackma9604 deleted the fix/MoveFn branch January 28, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interop vdom / vapor interop ready to merge The PR is ready to be merged. scope: vapor related to vapor mode

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants