Skip to content

fix(runtime-core): remove constructor props for defineComponent#14223

Merged
edison1105 merged 2 commits intovuejs:minorfrom
zhiyuanzmj:revert-types
Dec 18, 2025
Merged

fix(runtime-core): remove constructor props for defineComponent#14223
edison1105 merged 2 commits intovuejs:minorfrom
zhiyuanzmj:revert-types

Conversation

@zhiyuanzmj
Copy link
Copy Markdown
Member

@zhiyuanzmj zhiyuanzmj commented Dec 18, 2025

revert #13831 runtime-core changes.

Copilot AI review requested due to automatic review settings December 18, 2025 09:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 18, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 18, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.6 kB 36.5 kB
vue.global.prod.js 166 kB 60.5 kB 53.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB 18.9 kB 17.3 kB
createApp 57.2 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 96.3 kB 35.6 kB 32 kB
createVaporApp 42.3 kB 15.6 kB 14.2 kB
createSSRApp 61.6 kB 23.8 kB 21.7 kB
defineCustomElement 63.3 kB 23.9 kB 21.8 kB
overall 71.9 kB 27.2 kB 24.8 kB

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 18, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14223

npm i https://pkg.pr.new/@vue/compiler-core@14223

yarn add https://pkg.pr.new/@vue/compiler-core@14223.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14223

npm i https://pkg.pr.new/@vue/compiler-dom@14223

yarn add https://pkg.pr.new/@vue/compiler-dom@14223.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14223

npm i https://pkg.pr.new/@vue/compiler-sfc@14223

yarn add https://pkg.pr.new/@vue/compiler-sfc@14223.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14223

npm i https://pkg.pr.new/@vue/compiler-ssr@14223

yarn add https://pkg.pr.new/@vue/compiler-ssr@14223.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14223

npm i https://pkg.pr.new/@vue/compiler-vapor@14223

yarn add https://pkg.pr.new/@vue/compiler-vapor@14223.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14223

npm i https://pkg.pr.new/@vue/reactivity@14223

yarn add https://pkg.pr.new/@vue/reactivity@14223.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14223

npm i https://pkg.pr.new/@vue/runtime-core@14223

yarn add https://pkg.pr.new/@vue/runtime-core@14223.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14223

npm i https://pkg.pr.new/@vue/runtime-dom@14223

yarn add https://pkg.pr.new/@vue/runtime-dom@14223.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14223

npm i https://pkg.pr.new/@vue/runtime-vapor@14223

yarn add https://pkg.pr.new/@vue/runtime-vapor@14223.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14223

npm i https://pkg.pr.new/@vue/server-renderer@14223

yarn add https://pkg.pr.new/@vue/server-renderer@14223.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14223

npm i https://pkg.pr.new/@vue/shared@14223

yarn add https://pkg.pr.new/@vue/shared@14223.tgz

vue

pnpm add https://pkg.pr.new/vue@14223

npm i https://pkg.pr.new/vue@14223

yarn add https://pkg.pr.new/vue@14223.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14223

npm i https://pkg.pr.new/@vue/compat@14223

yarn add https://pkg.pr.new/@vue/compat@14223.tgz

commit: 71e9995

Copilot AI reviewed Dec 18, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the runtime-core changes from PR #13831 by removing typed constructor props from defineComponent. The change affects constructor signatures across multiple component-related types, replacing typed props parameters with generic ...args: any[] parameters.

  • Reverts constructor signatures from new (props?: T['props']) to new (...args: any[])
  • Updates JSX type definitions for Vapor runtime to properly support TypeScript JSX inference
  • Updates test type declarations to align with the reverted constructor signatures

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/runtime-vapor/src/apiDefineComponent.ts Reverts VaporComponentInstanceConstructor to use ...args: any[]
packages/runtime-dom/src/components/TransitionGroup.ts Removes props parameter from TransitionGroup constructor
packages/runtime-core/src/h.ts Reverts Constructor interface to use ...args: any[] (contains typo)
packages/runtime-core/src/components/Teleport.ts Removes props parameter from Teleport constructor
packages/runtime-core/src/components/Suspense.ts Removes props parameter from Suspense constructor
packages/runtime-core/src/components/KeepAlive.ts Removes props parameter from KeepAlive constructor
packages/runtime-core/src/componentPublicInstance.ts Reverts ComponentPublicInstanceConstructor to use ...args: any[]
packages/runtime-core/src/component.ts Simplifies ComponentInstance type to use parameterless constructor
packages-private/dts-test/vapor/jsx.d.ts Adds ElementClass and ElementAttributesProperty for JSX support
packages-private/dts-test/defineComponent.test-d.tsx Updates test to match reverted constructor signature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105
Copy link
Copy Markdown
Member

edison1105 commented Dec 18, 2025

/ecosystem-ci run

@vue-bot
Copy link
Copy Markdown
Contributor

vue-bot commented Dec 18, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
primevue ✅ success ✅ success
pinia ✅ success ✅ success
language-tools ⏹️ cancelled ❌ failure
nuxt ❌ failure ✅ success
quasar ✅ success ✅ success
vant ✅ success ✅ success
vuetify ❌ failure ❌ failure
vue-i18n ✅ success ❌ failure
router ✅ success ✅ success
radix-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-macros ❌ failure ❌ failure
vite-plugin-vue ✅ success ✅ success
test-utils ❌ failure ✅ success
vue-simple-compiler ✅ success ✅ success
vueuse ❌ failure ✅ success

@edison1105 edison1105 merged commit ad0a237 into vuejs:minor Dec 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

version: minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiyuanzmj @edison1105 @vue-bot