fix(compiler-vapor): camelize kebab-case component event handlers#14211
Merged
edison1105 merged 1 commit intominorfrom Dec 17, 2025
Merged
fix(compiler-vapor): camelize kebab-case component event handlers#14211edison1105 merged 1 commit intominorfrom
edison1105 merged 1 commit intominorfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Pull request overview
This PR fixes the Vapor compiler to properly camelize kebab-case component event handlers, aligning its behavior with the standard Vue compiler. Previously, kebab-case event names like @update-model were incorrectly kept as "onUpdate-model" instead of being converted to onUpdateModel.
Key Changes:
- Apply
camelizetransformation to static event handler keys before converting them to handler format - Update existing test expectations to reflect the corrected behavior
- Add new test case specifically for kebab-case event handler camelization
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compiler-vapor/src/generators/prop.ts | Imports camelize and applies it to static handler keys before toHandlerKey conversion |
| packages/compiler-vapor/tests/transforms/vOn.spec.ts | Updates test expectation for @update-model to generate camelized onUpdateModel and adds new test for kebab-case camelization |
| packages/compiler-vapor/tests/transforms/snapshots/vOn.spec.ts.snap | Updates snapshots to reflect corrected camelized output for kebab-case handlers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.