perf(runtime-vapor): implement dynamic props/slots source caching#14208
Merged
edison1105 merged 5 commits intominorfrom Dec 16, 2025
Merged
perf(runtime-vapor): implement dynamic props/slots source caching#14208edison1105 merged 5 commits intominorfrom
edison1105 merged 5 commits intominorfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Pull request overview
This PR implements a performance optimization by adding caching for dynamic props and slots sources. Previously, when a component accessed multiple props from the same v-bind source (e.g., v-bind="obj"), the source function was called multiple times. Now it's cached using a computed ref, so the source is only evaluated once per reactive update cycle.
Key changes:
- Created a generic
resolveDynamicFunctionSourceutility that caches function results using computed refs - Consolidated caching logic from
componentSlots.tsintocomponentProps.tsfor reuse - Updated all dynamic source resolution sites to use the new caching function
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/runtime-vapor/src/componentSlots.ts |
Removed local resolveDynamicSlot function and updated to use the shared resolveDynamicFunctionSource from componentProps |
packages/runtime-vapor/src/componentProps.ts |
Added resolveDynamicFunctionSource with computed-based caching and scope disposal, updated all dynamic source resolution call sites to use it |
packages/runtime-vapor/__tests__/componentProps.spec.ts |
Added comprehensive tests validating that v-bind sources are cached when multiple props are accessed and that reactivity still works correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.