Skip to content

fix(hmr): suppress provide warning during HMR updates for mounted instances#14195

Merged
edison1105 merged 1 commit intominorfrom
edison/fix/RouterViewRerender
Dec 15, 2025
Merged

fix(hmr): suppress provide warning during HMR updates for mounted instances#14195
edison1105 merged 1 commit intominorfrom
edison/fix/RouterViewRerender

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Dec 12, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 12, 2025 10:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/RouterViewRerender

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 12, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.6 kB 36.5 kB
vue.global.prod.js 166 kB 60.5 kB 53.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB 18.9 kB 17.3 kB
createApp 57.2 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 96.1 kB 35.5 kB 32 kB
createVaporApp 42.1 kB 15.5 kB 14.1 kB
createSSRApp 61.6 kB 23.8 kB 21.7 kB
defineCustomElement 63.3 kB 23.9 kB 21.8 kB
overall 71.9 kB 27.2 kB 24.8 kB

Copilot AI reviewed Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a false positive warning that occurs when provide() is called during HMR (Hot Module Replacement) updates on already-mounted component instances. The warning "provide() can only be used inside setup()" was incorrectly triggered during legitimate HMR reloads, particularly in components like router-view that call setup during re-renders.

  • Adds HMR context check to suppress provide() warning during hot updates
  • Includes test coverage for the router-view-like scenario where setup is re-executed on HMR reload

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/runtime-core/src/apiInject.ts Adds isHmrUpdating check to the provide() validation to suppress warnings during HMR updates for mounted instances
packages/runtime-vapor/tests/hmr.spec.ts Adds test case that simulates a router-view component scenario and verifies the warning is not shown during HMR reload

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 13, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14195

npm i https://pkg.pr.new/@vue/compiler-core@14195

yarn add https://pkg.pr.new/@vue/compiler-core@14195.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14195

npm i https://pkg.pr.new/@vue/compiler-dom@14195

yarn add https://pkg.pr.new/@vue/compiler-dom@14195.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14195

npm i https://pkg.pr.new/@vue/compiler-sfc@14195

yarn add https://pkg.pr.new/@vue/compiler-sfc@14195.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14195

npm i https://pkg.pr.new/@vue/compiler-ssr@14195

yarn add https://pkg.pr.new/@vue/compiler-ssr@14195.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14195

npm i https://pkg.pr.new/@vue/compiler-vapor@14195

yarn add https://pkg.pr.new/@vue/compiler-vapor@14195.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14195

npm i https://pkg.pr.new/@vue/reactivity@14195

yarn add https://pkg.pr.new/@vue/reactivity@14195.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14195

npm i https://pkg.pr.new/@vue/runtime-core@14195

yarn add https://pkg.pr.new/@vue/runtime-core@14195.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14195

npm i https://pkg.pr.new/@vue/runtime-dom@14195

yarn add https://pkg.pr.new/@vue/runtime-dom@14195.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14195

npm i https://pkg.pr.new/@vue/runtime-vapor@14195

yarn add https://pkg.pr.new/@vue/runtime-vapor@14195.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14195

npm i https://pkg.pr.new/@vue/server-renderer@14195

yarn add https://pkg.pr.new/@vue/server-renderer@14195.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14195

npm i https://pkg.pr.new/@vue/shared@14195

yarn add https://pkg.pr.new/@vue/shared@14195.tgz

vue

pnpm add https://pkg.pr.new/vue@14195

npm i https://pkg.pr.new/vue@14195

yarn add https://pkg.pr.new/vue@14195.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14195

npm i https://pkg.pr.new/@vue/compat@14195

yarn add https://pkg.pr.new/@vue/compat@14195.tgz

commit: eadd8b2

@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 15, 2025
@edison1105 edison1105 force-pushed the edison/fix/RouterViewRerender branch from b3cde3f to eadd8b2 Compare December 15, 2025 02:34
@edison1105 edison1105 merged commit d823d6a into minor Dec 15, 2025
17 checks passed
@edison1105 edison1105 deleted the edison/fix/RouterViewRerender branch December 15, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edison1105