fix(hmr): track original __vapor state during component mode switching#14187
Merged
edison1105 merged 2 commits intominorfrom Dec 11, 2025
Merged
fix(hmr): track original __vapor state during component mode switching#14187edison1105 merged 2 commits intominorfrom
__vapor state during component mode switching#14187edison1105 merged 2 commits intominorfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
4f4d13c to
9870a55
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes an HMR bug where switching components between Vapor and VDOM modes caused incorrect behavior during unmount/move operations. The fix introduces a tracking mechanism to preserve the original __vapor state of components before they are mutated during HMR reload.
- Adds
hmrDirtyComponentsModeMap to track original vapor state of dirty components - Introduces
isVaporComponent()helper function to check component vapor state with HMR awareness - Replaces direct
__vaporproperty access withisVaporComponent()in operations on existing VNodes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/runtime-core/src/hmr.ts | Adds hmrDirtyComponentsMode Map to track original __vapor state before mutation, populates it during component reload, and clears it post-update |
| packages/runtime-core/src/renderer.ts | Implements isVaporComponent() helper that checks the HMR tracking map during reload, and updates move, unmount, deactivate, and getNextHostNode functions to use it |
| packages/runtime-core/src/components/BaseTransition.ts | Updates recursiveGetSubtree and setTransitionHooks to use isVaporComponent() instead of direct __vapor access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
__vapor state of components during HMR reload__vapor state during component mode switching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.