pref(slots): use computed to cache the result of dynamic slot function to avoid redundant calls#14176
Merged
edison1105 merged 1 commit intominorfrom Dec 8, 2025
Merged
pref(slots): use computed to cache the result of dynamic slot function to avoid redundant calls#14176edison1105 merged 1 commit intominorfrom
edison1105 merged 1 commit intominorfrom
Conversation
…function to avoid redundant calls.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Pull request overview
This PR optimizes dynamic slot rendering performance by caching the results of dynamic slot functions using Vue's computed API, preventing redundant function calls within the same render cycle.
- Adds a caching mechanism using
computedfor dynamic slot functions - Introduces the
resolveDynamicSlothelper to manage cache lifecycle - Reorganizes tests into a dedicated
createForSlotsdescribe block with comprehensive caching behavior tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/runtime-vapor/src/componentSlots.ts | Adds _cache property to DynamicSlotFn type, implements resolveDynamicSlot helper function, and updates call sites to use the caching mechanism |
| packages/runtime-vapor/tests/componentSlots.spec.ts | Reorganizes existing test into createForSlots describe block and adds three new tests verifying caching behavior, reactivity updates, and correct rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.