fix(slot): enhance v-slot prop destructuring support#14165
Merged
edison1105 merged 2 commits intominorfrom Dec 4, 2025
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Size ReportBundles
Usages
|
There was a problem hiding this comment.
Pull request overview
This PR enhances v-slot prop destructuring support by refactoring the destructuring logic to be shared between v-for and v-slot implementations. The key improvement is that slot props now use proper accessor paths (dot notation for simple properties, computed access for dynamic keys) instead of always using bracket notation.
- Extracts
parseValueDestructureandbuildDestructureIdMapfunctions from v-for implementation to make them reusable - Updates v-slot handling to use the shared destructuring logic, enabling support for nested destructuring, computed keys, rest elements, and default values
- Changes generated code from bracket notation (
_slotProps0["foo"]) to dot notation (_slotProps0.foo) for cleaner output
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compiler-vapor/src/generators/for.ts | Extracts parseValueDestructure and buildDestructureIdMap as exported functions to enable reuse; refactors the v-for implementation to use the new functions |
| packages/compiler-vapor/src/generators/component.ts | Updates slot prop handling to use the shared destructuring functions, removing the simpler bracket-notation-only logic and enabling full destructuring support |
| packages/compiler-vapor/tests/transforms/vSlot.spec.ts | Adds comprehensive test cases for alias, nested, computed key, rest, and default value destructuring; updates existing test expectations to use dot notation |
| packages/compiler-vapor/tests/transforms/snapshots/vSlot.spec.ts.snap | Updates all snapshots to reflect the new dot notation output and adds snapshots for new test cases |
| packages/compiler-vapor/tests/snapshots/scopeId.spec.ts.snap | Updates snapshot to use dot notation for slot prop access |
| packages/compiler-vapor/tests/snapshots/compile.spec.ts.snap | Updates snapshot to use dot notation for slot prop access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhiyuanzmj
added a commit
to vuejs/vue-jsx-vapor
that referenced
this pull request
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.