Skip to content

fix(templateRef): prevent duplicate onScopeDispose registrations for dynamic template refs#14161

Merged
edison1105 merged 4 commits intominorfrom
edison/fix/templateRef
Dec 3, 2025
Merged

fix(templateRef): prevent duplicate onScopeDispose registrations for dynamic template refs#14161
edison1105 merged 4 commits intominorfrom
edison/fix/templateRef

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Dec 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 03:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/templateRef

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 3, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.5 kB 36.4 kB
vue.global.prod.js 166 kB 60.5 kB 53.8 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48 kB 18.8 kB 17.1 kB
createApp 57 kB 21.9 kB 20 kB
createApp + vaporInteropPlugin 95.4 kB 35.2 kB 31.7 kB
createVaporApp 40.6 kB 15.1 kB 13.7 kB
createSSRApp 61.4 kB 23.7 kB 21.6 kB
defineCustomElement 63.1 kB 23.8 kB 21.7 kB
overall 72.1 kB 27.3 kB 24.9 kB

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 3, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14161

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14161

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14161

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14161

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14161

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14161

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14161

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14161

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14161

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14161

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14161

vue

npm i https://pkg.pr.new/vue@14161

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14161

commit: 4eaff71

Copilot AI reviewed Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the template ref handling in runtime-vapor by conditionally creating the canSetSetupRef checker only in development mode. In production builds, it uses the NO constant instead, avoiding unnecessary function creation and setup state access.

Key Changes

  • Replaced direct hasOwn check with the more comprehensive canSetSetupRef function that provides additional dev-mode warnings
  • Conditionally creates canSetSetupRef only when __DEV__ is true, using NO as a fallback in production
  • Updated imports to replace hasOwn with NO

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 changed the title fix(runtime-vapor): conditionally enable canSetSetupRef check in dev mode fix(templateRef): prevent duplicate onScopeDispose registrations for dynamic template refs Dec 3, 2025
@edison1105 edison1105 added version: minor scope: vapor related to vapor mode labels Dec 3, 2025
@edison1105 edison1105 requested a review from Copilot December 3, 2025 07:04
Copilot AI reviewed Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 merged commit 750e7cd into minor Dec 3, 2025
23 checks passed
@edison1105 edison1105 deleted the edison/fix/templateRef branch December 3, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

scope: vapor related to vapor mode version: minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edison1105