Skip to content

fix(vapor): handle next host node for vapor component#13823

Merged
edison1105 merged 2 commits intovuejs:minorfrom
jackma9604:fix/vapor_uninstallation_issue
Aug 29, 2025
Merged

fix(vapor): handle next host node for vapor component#13823
edison1105 merged 2 commits intovuejs:minorfrom
jackma9604:fix/vapor_uninstallation_issue

Conversation

@jackma9604
Copy link
Copy Markdown

@jackma9604 jackma9604 commented Aug 29, 2025

@jackma9604
fix(runtime-core): Failed to execute 'insertBefore' on 'Node': The no…
8e5c0e9 
…de before which the new node is to be inserted is not a child of this node.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbit review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 29, 2025 •
edited
Loading

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 64f5a61
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68b15ae6926fc10008e4bdd6

@jackma9604
Copy link
Copy Markdown
Author

jackma9604 commented Aug 29, 2025

#13824

@jackma9604 jackma9604 mentioned this pull request Aug 29, 2025
Closed
edison1105
edison1105 reviewed Aug 29, 2025
View reviewed changes
packages/runtime-core/src/renderer.ts Outdated
if (vnode.shapeFlag & ShapeFlags.COMPONENT) {
if ((vnode.type as ConcreteComponent).__vapor) {
return hostNextSibling((vnode.component! as any).block)
const next = hostNextSibling((vnode.component! as any).block)
Copy link
Copy Markdown
Member

@edison1105 edison1105 Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be vnode.anchor
I have already fixed it at #12962

core/packages/runtime-core/src/renderer.ts

Line 2514 in 98e1dd1

return hostNextSibling(vnode.anchor!)

@edison1105 edison1105 changed the title fix(runtime-core): Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node. fix(vapor): handle next host node for vapor component Aug 29, 2025
@edison1105 edison1105 added the scope: vapor related to vapor mode label Aug 29, 2025
@edison1105 edison1105 linked an issue Aug 29, 2025 that may be closed by this pull request
[Vapor] Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node. #13824
Closed
@edison1105 edison1105 merged commit 96ca3b0 into vuejs:minor Aug 29, 2025
2 of 6 checks passed
@jackma9604 jackma9604 deleted the fix/vapor_uninstallation_issue branch September 4, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Vapor] Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.

2 participants

@jackma9604 @edison1105