Skip to content

fix(reactivity): remove link check to align with 3.5#13654

Merged
edison1105 merged 3 commits intovuejs:minorfrom
Doctor-wu:fix/link-check
Jul 18, 2025
Merged

fix(reactivity): remove link check to align with 3.5#13654
edison1105 merged 3 commits intovuejs:minorfrom
Doctor-wu:fix/link-check

Conversation

@Doctor-wu
Copy link
Copy Markdown
Member

@Doctor-wu Doctor-wu commented Jul 18, 2025

fix #13620

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 18, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 18, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.1 kB 29.8 kB 26.2 kB
runtime-dom.global.prod.js 104 kB (-64 B) 39.1 kB (-36 B) 35.2 kB (-17 B)
vue.global.prod.js 162 kB (-64 B) 59.3 kB (-30 B) 52.8 kB (+61 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.1 kB (-64 B) 18.4 kB (-24 B) 16.9 kB (-5 B)
createApp 56 kB (-64 B) 21.6 kB (-44 B) 19.7 kB (-16 B)
createApp + vaporInteropPlugin 68.5 kB (-64 B) 25.8 kB (-22 B) 23.5 kB (-78 B)
createVaporApp 20.9 kB (-191 B) 8.26 kB (-63 B) 7.57 kB (-55 B)
createSSRApp 60.3 kB (-64 B) 23.3 kB (-20 B) 21.3 kB (+3 B)
defineCustomElement 61 kB (-64 B) 23.1 kB (-17 B) 21.1 kB (-15 B)
overall 70.5 kB (-64 B) 26.8 kB (-34 B) 24.5 kB (+6 B)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jul 18, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13654

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13654

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13654

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13654

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13654

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13654

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13654

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13654

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13654

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13654

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13654

vue

npm i https://pkg.pr.new/vue@13654

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13654

commit: c15992c

@Doctor-wu Doctor-wu marked this pull request as draft July 18, 2025 06:04
@Doctor-wu Doctor-wu marked this pull request as ready for review July 18, 2025 06:14
@Doctor-wu Doctor-wu requested a review from johnsoncodehk July 18, 2025 06:14
@Doctor-wu Doctor-wu changed the title fix(reactivity): remove unnecessary link check fix(reactivity): remove link check to align with 3.5 Jul 18, 2025
@edison1105 edison1105 moved this to Vapor in Next Minor Jul 18, 2025
@edison1105 edison1105 added scope: reactivity ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Jul 18, 2025
@edison1105 edison1105 linked an issue Jul 18, 2025 that may be closed by this pull request
perf regression real world use case #13620
Closed
@LittleSound LittleSound mentioned this pull request Jul 18, 2025
Closed
@edison1105 edison1105 merged commit 3cb27d1 into vuejs:minor Jul 18, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Vapor to Done in Next Minor Jul 18, 2025
@edison1105 edison1105 mentioned this pull request Jul 18, 2025
Closed
johnsoncodehk added a commit to stackblitz/alien-signals that referenced this pull request Jul 22, 2025
@johnsoncodehk
fix(reactivity): remove non-contiguous dep checks
eafb4c4 
Sync with vuejs/core#13654
johnsoncodehk added a commit to stackblitz/alien-signals that referenced this pull request Aug 1, 2025
@johnsoncodehk
fix(system): remove non-contiguous dep checks
7d801e7 
Sync with vuejs/core#13654
@johnsoncodehk johnsoncodehk mentioned this pull request Aug 21, 2025
Merged
@github-actions github-actions bot mentioned this pull request Aug 21, 2025
Merged
@johnsoncodehk johnsoncodehk mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@johnsoncodehk johnsoncodehk johnsoncodehk approved these changes

@LittleSound LittleSound LittleSound approved these changes

@baiwusanyu-c baiwusanyu-c baiwusanyu-c approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: reactivity version: minor

Projects

Next Minor
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

perf regression real world use case

5 participants

@Doctor-wu @johnsoncodehk @LittleSound @baiwusanyu-c @edison1105