Skip to content

fix(runtime-vapor): handle vapor attrs fallthrough to vdom component#13551

Merged
edison1105 merged 5 commits intominorfrom
edison/fix/vdomCompAttrFallthrough
Sep 2, 2025
Merged

fix(runtime-vapor): handle vapor attrs fallthrough to vdom component#13551
edison1105 merged 5 commits intominorfrom
edison/fix/vdomCompAttrFallthrough

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Jul 1, 2025 •
edited
Loading

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 1, 2025 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 3909800
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/68674ea93dfc220007da8f1b
😎 Deploy Preview https://deploy-preview-13551--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 1, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vdomCompAttrFallthrough
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@edison1105 edison1105 added the scope: vapor related to vapor mode label Jul 1, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jul 1, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13551

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13551

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13551

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13551

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13551

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13551

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13551

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13551

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13551

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13551

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13551

vue

npm i https://pkg.pr.new/vue@13551

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13551

commit: 80bc02f

@edison1105 edison1105 force-pushed the edison/fix/vdomCompAttrFallthrough branch from 05be5cf to 000d4d0 Compare July 3, 2025 08:46
Base automatically changed from vapor to minor July 7, 2025 00:06
@edison1105 edison1105 moved this to Vapor in Next Minor Jul 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.6 kB 25.9 kB 23.6 kB
createVaporApp 20.9 kB 8.26 kB 7.57 kB
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 1, 2025

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 80bc02f
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68b54855ebe9f800085125ad

@edison1105 edison1105 merged commit 5ce227b into minor Sep 2, 2025
13 of 17 checks passed
@github-project-automation github-project-automation bot moved this from Vapor to Done in Next Minor Sep 2, 2025
@edison1105 edison1105 deleted the edison/fix/vdomCompAttrFallthrough branch September 2, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

@LittleSound LittleSound Awaiting requested review from LittleSound

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

Next Minor
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edison1105