Skip to content

feat(vapor): templateRef vdom interop#13323

Merged
edison1105 merged 9 commits intominorfrom
edison/fix/setRefVdomInterop
Oct 20, 2025
Merged

feat(vapor): templateRef vdom interop#13323
edison1105 merged 9 commits intominorfrom
edison/fix/setRefVdomInterop

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented May 13, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented May 13, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/setRefVdomInterop

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify bot commented May 13, 2025 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 297855a
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/685500ecb429e400080347d3
😎 Deploy Preview https://deploy-preview-13323--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@edison1105 edison1105 force-pushed the edison/fix/setRefVdomInterop branch from 72c8f22 to eaee515 Compare May 13, 2025 09:22
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented May 13, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13323

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13323

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13323

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13323

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13323

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13323

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13323

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13323

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13323

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13323

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13323

vue

npm i https://pkg.pr.new/vue@13323

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13323

commit: 3e097c2

@edison1105 edison1105 changed the title feat(vapor): setRef vdom interop feat(vapor): templateRef vdom interop May 14, 2025
@edison1105 edison1105 mentioned this pull request May 14, 2025
Merged
edison1105
edison1105 commented May 14, 2025
View reviewed changes
packages/runtime-core/src/rendererTemplateRef.ts Outdated
const rawSetupState = toRaw(setupState)
const canSetSetupRef =
setupState === EMPTY_OBJ
setupState === undefined || setupState === EMPTY_OBJ
Copy link
Copy Markdown
Member Author

@edison1105 edison1105 May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no setupState on vapor component instance

@edison1105 edison1105 marked this pull request as ready for review May 14, 2025 03:20
@edison1105 edison1105 added the scope: vapor related to vapor mode label May 14, 2025
@edison1105 edison1105 force-pushed the edison/fix/setRefVdomInterop branch from 431b426 to 99ec225 Compare May 15, 2025 00:17
@edison1105 edison1105 added ready to merge The PR is ready to be merged. and removed ready to merge The PR is ready to be merged. labels Jun 18, 2025
Base automatically changed from vapor to minor July 7, 2025 00:06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.5 kB 30 kB 26.4 kB
runtime-dom.global.prod.js 105 kB (+16 B) 39.4 kB (+6 B) 35.5 kB (+28 B)
vue.global.prod.js 163 kB (+16 B) 59.6 kB (+1 B) 53.1 kB (+12 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.4 kB (+16 B) 18.5 kB (+7 B) 16.9 kB (+8 B)
createApp 56.2 kB (+16 B) 21.7 kB (+8 B) 19.8 kB (+8 B)
createApp + vaporInteropPlugin 80 kB (+124 B) 29.9 kB (+50 B) 27.2 kB (+33 B)
createVaporApp 31.3 kB 12 kB 11 kB
createSSRApp 60.5 kB (+16 B) 23.4 kB (+6 B) 21.4 kB (+6 B)
defineCustomElement 61.2 kB (+16 B) 23.2 kB (+5 B) 21.2 kB (+7 B)
overall 71.1 kB (+16 B) 27 kB (+7 B) 24.7 kB (+50 B)

@LittleSound LittleSound mentioned this pull request Jul 22, 2025
Open
22 tasks
@edison1105 edison1105 merged commit 436eda7 into minor Oct 20, 2025
17 checks passed
@edison1105 edison1105 deleted the edison/fix/setRefVdomInterop branch October 20, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edison1105