Skip to content

fix(reactivity): queuing effects in an array#13078

Merged
yyx990803 merged 15 commits intovuejs:minorfrom
johnsoncodehk:effect-queuing
Mar 31, 2025
Merged

fix(reactivity): queuing effects in an array#13078
yyx990803 merged 15 commits intovuejs:minorfrom
johnsoncodehk:effect-queuing

Conversation

@johnsoncodehk
Copy link
Copy Markdown
Member

@johnsoncodehk johnsoncodehk commented Mar 20, 2025 •
edited
Loading

Originally reported at stackblitz/alien-signals#48

Reusing nextDep to queued effects is unreliable if the effect changes dependencies in a side effect.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (-118 B) 38.3 kB (-10 B) 34.5 kB (-49 B)
vue.global.prod.js 159 kB (-119 B) 58.4 kB (-13 B) 52 kB (+94 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB (-123 B) 18.3 kB (-55 B) 16.7 kB (-8 B)
createApp 55 kB (-142 B) 21.4 kB (-26 B) 19.5 kB (-36 B)
createSSRApp 59.2 kB (-142 B) 23.1 kB (-30 B) 21.1 kB (-32 B)
defineCustomElement 59.8 kB (-128 B) 22.9 kB (-47 B) 20.9 kB (-39 B)
overall 69.2 kB (-112 B) 26.6 kB (+10 B) 24.2 kB (-29 B)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 20, 2025 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13078

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13078

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13078

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13078

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13078

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13078

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13078

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13078

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13078

vue

npm i https://pkg.pr.new/vue@13078

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13078

commit: 74c617b

@johnsoncodehk johnsoncodehk marked this pull request as draft March 21, 2025 02:06
@johnsoncodehk johnsoncodehk marked this pull request as ready for review March 21, 2025 03:31
@johnsoncodehk johnsoncodehk changed the title fix(reactivity): dont using a chain table to queuing effects fix(reactivity): use linked list to queuing effects Mar 23, 2025
@edison1105
Copy link
Copy Markdown
Member

edison1105 commented Mar 25, 2025

/ecosystem-ci run

@johnsoncodehk johnsoncodehk changed the title fix(reactivity): use linked list to queuing effects fix(reactivity): queuing effects in an array Mar 27, 2025
@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 27, 2025

/ecosystem-ci run

@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 28, 2025

/ecosystem-ci run

@johnsoncodehk johnsoncodehk marked this pull request as draft March 28, 2025 07:03
@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 28, 2025

/ecosystem-ci run

@johnsoncodehk johnsoncodehk marked this pull request as ready for review March 28, 2025 09:01
@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 29, 2025

The vuetify test can stably reproduce the failure since 84663cc.

@edison1105
Copy link
Copy Markdown
Member

edison1105 commented Mar 29, 2025

/ecosystem-ci run

@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 31, 2025

/ecosystem-ci run

@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 31, 2025

/ecosystem-ci run

@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 31, 2025

/ecosystem-ci run

@johnsoncodehk
Copy link
Copy Markdown
Member Author

johnsoncodehk commented Mar 31, 2025

/ecosystem-ci run

@vue-bot
Copy link
Copy Markdown
Contributor

vue-bot commented Mar 31, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
nuxt ✅ success ✅ success
language-tools ✅ success ✅ success
primevue ✅ success ✅ success
pinia ✅ success ✅ success
router ✅ success ✅ success
radix-vue ✅ success ✅ success
vuetify ✅ success ✅ success
test-utils ✅ success ✅ success
vue-macros ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vueuse ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
quasar ✅ success ✅ success

@yyx990803 yyx990803 merged commit 826550c into vuejs:minor Mar 31, 2025
13 checks passed
@johnsoncodehk johnsoncodehk deleted the effect-queuing branch April 1, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready to merge The PR is ready to be merged. scope: reactivity version: minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnsoncodehk @edison1105 @vue-bot @yyx990803