Skip to content

feat(vapor): defineVaporAsyncComponent#13059

Merged
edison1105 merged 14 commits intominorfrom
edison/feat/vaporAsyncComponent
Oct 20, 2025
Merged

feat(vapor): defineVaporAsyncComponent#13059
edison1105 merged 14 commits intominorfrom
edison/feat/vaporAsyncComponent

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Mar 18, 2025 •
edited
Loading

  • Added defineVaporAsyncComponent API
  • Extracted shared logic from apiAsyncComponent.ts by creating createAsyncComponentContext and useAsyncComponentState utility functions, shared between core and vapor
  • Added support for template ref forwarding
  • Ported all test cases from apiAsyncComponent.spec.ts except Suspense and KeepAlive related ones

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 18, 2025 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 637b3cb
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/6854fb2e988c0400084ba450
😎 Deploy Preview https://deploy-preview-13059--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 18, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13059

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13059

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13059

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13059

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13059

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13059

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13059

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13059

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13059

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13059

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13059

vue

npm i https://pkg.pr.new/vue@13059

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13059

commit: f8ffcc5

@edison1105 edison1105 force-pushed the edison/feat/vaporAsyncComponent branch from e629893 to 8d77c1f Compare March 18, 2025 03:18
@edison1105 edison1105 added the scope: vapor related to vapor mode label Mar 18, 2025
@edison1105 edison1105 force-pushed the edison/feat/vaporAsyncComponent branch from ae3b980 to 307f757 Compare March 19, 2025 02:56
@edison1105 edison1105 marked this pull request as ready for review March 19, 2025 03:17
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 20, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/feat/vaporAsyncComponent

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from vapor to minor July 7, 2025 00:06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.5 kB 30 kB 26.4 kB
runtime-dom.global.prod.js 105 kB (+253 B) 39.5 kB (+103 B) 35.6 kB (+56 B)
vue.global.prod.js 163 kB (+253 B) 59.7 kB (+93 B) 53.2 kB (+53 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.4 kB 18.5 kB 16.9 kB
createApp 56.2 kB 21.7 kB 19.8 kB
createApp + vaporInteropPlugin 80 kB 29.9 kB 27.2 kB
createVaporApp 31.3 kB 12 kB 11 kB
createSSRApp 60.5 kB 23.4 kB 21.4 kB
defineCustomElement 61.2 kB 23.2 kB 21.2 kB
overall 71.1 kB 27 kB 24.7 kB

@LittleSound LittleSound mentioned this pull request Jul 22, 2025
Open
22 tasks
Not-Minimal
Not-Minimal reviewed Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown

@Not-Minimal Not-Minimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@edison1105 edison1105 merged commit 6ec403f into minor Oct 20, 2025
15 of 17 checks passed
@edison1105 edison1105 deleted the edison/feat/vaporAsyncComponent branch October 20, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Not-Minimal Not-Minimal Not-Minimal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

scope: vapor related to vapor mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edison1105 @Not-Minimal