Conversation
Changed build-in presets to support subfolders, added new presets and removed some not-so-great sounding ones, tried to gain-stage the presets alittle.
|
Thanks! I see these are three separate things, so please rewrite git history to make them into three separate pull requests / commits, so I can review them more easily & merge them one by one. I don't have time to test these tonight, but I already have some questions:
The presets adjustment could be pull request with four commits. For example: first commit renaming all existing presets into better names; second commit adding new presets; third commit tweaking the gains; and fourth commit deleting the presets that you think are bad. These commits are in the order of agreeableness: I might agree the merge the first three, but not the fourth. Having them in four clean commits helps the review process. |
|
Any chance of cleaning up this pull request? I might look into it to get the gain staged instruments, but that "79 files changed" is a bit intimidating, without more context. |
|
I put the presets in & closed this pull request for now. Please open other pull requests if you still want those UI tweaks (but some things may have changed since then, so the code may not be directly compatible with latest master). |
Adds peak volume to vu metter and change color to red when audio clips.
Changed build-in presets to support subfolders.
Added new presets and removed some not-so-great sounding ones, tried to gain-stage the presets.