Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a4f47b8b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| swiftSettings: [ | ||
| .enableUpcomingFeature("NonisolatedNonsendingByDefault"), | ||
| .enableUpcomingFeature("ExistentialAny"), | ||
| .enableUpcomingFeature("MemberImportVisibility"), | ||
| .treatAllWarnings(as: .error) | ||
| .enableUpcomingFeature("MemberImportVisibility") |
There was a problem hiding this comment.
Preserve warnings-as-errors in SwiftPM CI builds
Removing .treatAllWarnings(as: .error) from the manifest drops this check for every workflow that builds via SwiftPM instead of Xcode. In this repo, the macOS/Linux/Windows/WASM jobs all call swift build directly (.github/workflows/ci.yml:245, 317, 382, 482), and CodeQL does the same in .github/workflows/codeql.yml:95-99, so the Xcode project setting no longer protects those environments. If a warning shows up only in one of those builds, CI will now pass silently and we lose the warning-free guard on shipped package configurations.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 40 40
Lines 3434 3434
=======================================
Hits 3291 3291
Misses 143 143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove treat warnings as errors from Swift package manifest, as this can cause integration issues for some SPM consumers in certain environments. The flag is still enabled in Xcode, and still use to validate CI builds.