Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf7624676d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "array", | ||
| "canada", | ||
| "twitter" |
There was a problem hiding this comment.
Fix benchmark resource name mismatch for new files
The new entries array, canada, and twitter are passed through load(benchmark:), which always prefixes the resource name as benchmark-<name>. That means this will look for benchmark-array.json, benchmark-canada.json, and benchmark-twitter.json, but the added resources are named array.json, canada.json, and twitter.json. When running benchmarks, Bundle.module.url(forResource:withExtension:) returns nil and the force unwrap crashes before any benchmarks run. Either rename the files to include the benchmark- prefix or adjust load to avoid the prefix for these entries.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 35 35
Lines 2879 2879
=======================================
Hits 2727 2727
Misses 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bf76246 to
0be70b1
Compare
No description provided.