Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b2c6e46a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| swift package --allow-writing-to-package-directory benchmark baseline update swiftyjson | ||
|
|
||
| swift package benchmark baseline compare foundation jbird --format markdown > Results/foundation.md |
There was a problem hiding this comment.
Recreate Results directory before redirecting output
Because the script deletes Results earlier (rm -rf Results on line 4), the first redirection to Results/foundation.md will fail if the directory no longer exists. In bash, redirections are evaluated before running the command, so this causes the compare command to never execute and the script exits with a “No such file or directory” error on a clean run. Add mkdir -p Results (or stop deleting it) before these redirects.
Useful? React with 👍 / 👎.
3b2c6e4 to
d99c6a6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 35 35
Lines 2879 2879
=======================================
Hits 2727 2727
Misses 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.