Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6704f448cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func getLibrary() -> Library { | ||
| let raw = ProcessInfo.processInfo.environment["BENCHMARK_TARGET"] | ||
| return raw.flatMap(Library.init)! | ||
| } |
There was a problem hiding this comment.
Avoid crashing when BENCHMARK_TARGET is used for deps
This now force-unwraps BENCHMARK_TARGET as one of foundation/jbird/swiftyjson/freddy, but the same env var is already used in Benchmarks/Package.swift for release/remote/local. When users set BENCHMARK_TARGET=local (or leave it unset) to pick the dependency source, Library.init returns nil and this line traps, so benchmarks no longer run unless the env value is changed to the new strings. Consider using a different env var name for the parser selection or providing a safe default.
Useful? React with 👍 / 👎.
6704f44 to
50d334d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 94.72% 94.75% +0.03%
==========================================
Files 35 35
Lines 2879 2879
==========================================
+ Hits 2727 2728 +1
+ Misses 152 151 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.