Skip to content

Remove JSON.Literal and refactor JSON.Number#303

Merged
vsanthanam merged 3 commits intomainfrom
vsanthanam/sketch
Dec 13, 2025
Merged

Remove JSON.Literal and refactor JSON.Number#303
vsanthanam merged 3 commits intomainfrom
vsanthanam/sketch

Conversation

@vsanthanam
Copy link
Copy Markdown
Owner

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.44%. Comparing base (bf9e0c8) to head (dcfdc78).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../JBirdCore/Protocols/JSONNumberRepresentable.swift 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   95.56%   95.44%   -0.13%     
==========================================
  Files          37       35       -2     
  Lines        2932     2851      -81     
==========================================
- Hits         2802     2721      -81     
  Misses        130      130              
Flag Coverage Δ
llvm-cov 95.44% <98.93%> (-0.13%) ⬇️
swiftpm 95.44% <98.93%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsanthanam vsanthanam changed the title [Sketch] Remove JSON.Literal [Sketch] Remove JSON.Literal and refactor JSON.Number Dec 9, 2025
@vsanthanam vsanthanam force-pushed the vsanthanam/sketch branch 4 times, most recently from fd6d6b3 to 19d69ad Compare December 10, 2025 16:01
@vsanthanam vsanthanam changed the title [Sketch] Remove JSON.Literal and refactor JSON.Number Remove JSON.Literal and refactor JSON.Number Dec 10, 2025
@vsanthanam vsanthanam force-pushed the vsanthanam/sketch branch 3 times, most recently from 3ceb2f0 to f5e6d65 Compare December 10, 2025 16:19
@vsanthanam vsanthanam marked this pull request as ready for review December 13, 2025 16:36
@vsanthanam vsanthanam merged commit 38a908d into main Dec 13, 2025
47 checks passed
@vsanthanam vsanthanam deleted the vsanthanam/sketch branch December 13, 2025 16:36
@vsanthanam vsanthanam linked an issue Dec 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete or Refactor Literal and Number types

1 participant