Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let array = JSON.build { | ||
| "12" | ||
| "nast" | ||
| 1.2 | ||
| 23 | ||
| nil | ||
| { | ||
| "key" => nil | ||
| } | ||
| } | ||
|
|
||
| let object = JSON.build { | ||
| "string" => 12 | ||
| "plop" => [nil, 12, "asd"] | ||
| } |
There was a problem hiding this comment.
Remove call to nonexistent JSON.build
This test file invokes JSON.build { … } twice, but the commit only added the JSON.Builder result-builder type and a couple of => helpers. Neither the existing JSON type nor the new extension define a static build factory, so JSON has no member named build and the module will not compile (Swift errors out before any tests run). Either add the missing API that wraps @JSON.Builder or call one of the existing initializers (e.g. JSON { … } or JSON(fields:)).
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 93.89% 93.90%
=======================================
Files 24 25 +1
Lines 1819 1870 +51
=======================================
+ Hits 1708 1756 +48
- Misses 111 114 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.