Skip to content

Conversation

@mikebski
Copy link
Contributor

@mikebski mikebski commented Oct 18, 2019

https://www.postgresql.org/docs/8.3/catalog-pg-attrdef.html

According to this page, the fix in this PR should work from PG 8.3 on.

@mikebski
Copy link
Contributor Author

@Hell4Ge
Copy link

Hell4Ge commented Oct 21, 2019

When will this be merged into official docker image?

@stiko
Copy link

stiko commented Oct 21, 2019

Any updates on this?

@fireartist
Copy link

Can confirm that commit 717d9e6 allows me to browse tables on postgres 12 (fedora 30)

@tinyoverflow
Copy link

I would like to see this merged. When will it be merged?

@salacr
Copy link
Contributor

salacr commented Nov 1, 2019

I can also confirm that this patch works, we didn't find any issue with that

@mikebski
Copy link
Contributor Author

mikebski commented Nov 7, 2019

Hi @vrana - any idea when you can merge/release this? It would be nice to have this get to the downstream docker stuff I'm using...

@renderpci
Copy link

HI mikebski, I try your patch for PostgreSQL 12 but don't wort for me in Adminer 4.7.4. I fix it using this in the line has change (note var $Dd instead $identity_column):

foreach (get_rows("SELECT a.attname AS field, format_type(a.atttypid, a.atttypmod) AS full_type, pg_get_expr(d.adbin, d.adrelid) AS default, a.attnotnull::int, col_description(c.oid, a.attnum) AS comment, $Dd AS identity

@mikebski
Copy link
Contributor Author

mikebski commented Nov 9, 2019

@renderpci - How did you patch it? If you just pasted this in to the compiled file, the variable name looks like it's different because it is minified. In the uncompiled source, the variable is $identity_column

@renderpci
Copy link

@mikebski - Yes, we prove it in the compiled file, we don't have Adminer dev version installed...

@vrana
Copy link
Owner

vrana commented Nov 11, 2019

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants