Merged
Conversation
Contributor
Author
|
Unfortunately I haven't been able to pinpoint the exact conditions where reading from stderr first causes a deadlock. I just know that it does for my particular codebase and swapping the reads fixes it. Since it seems like a harmless change, I figured it might be worth a PR despite not including any test coverage. |
Contributor
Author
|
I cannot provide my codebase, so I'll provide the next best thing which is a screen recording demonstrating the difference this PR makes for me: CleanShot.2025-01-03.at.17.40.48.mp4 |
Owner
|
Oh yeah, this looks like the correct ordering. Thanks so much for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases trying to read stderror before stdout can cause a deadlock. This PR swaps the order so stdout is read first.
Closes #12