Skip to content

Filter out invalid bins when loading package manifest#997

Merged
chriskrycho merged 1 commit intovolta-cli:mainfrom
charlespierce:skip_invalid_bins
May 3, 2022
Merged

Filter out invalid bins when loading package manifest#997
chriskrycho merged 1 commit intovolta-cli:mainfrom
charlespierce:skip_invalid_bins

Conversation

@charlespierce
Copy link
Copy Markdown
Contributor

Info

Changes

  • Updated the logic for parsing the bin hash to exclude any names that contain path separators (/ and \).

Tested

  • Installed the example from Discord (@ethersphere/swarm-cli) and confirmed that it failed before the change and succeeded afterwards.
    • Note: npm version 6 and lower appear to do some normalization of the package.json during a global install, so I was only able to reproduce the failure using npm 7.

@chriskrycho chriskrycho merged commit 1ad3d7c into volta-cli:main May 3, 2022
@charlespierce charlespierce deleted the skip_invalid_bins branch January 16, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants