Ignore non-json files when listing all package configs#981
Merged
chriskrycho merged 1 commit intovolta-cli:mainfrom Apr 30, 2021
Merged
Ignore non-json files when listing all package configs#981chriskrycho merged 1 commit intovolta-cli:mainfrom
chriskrycho merged 1 commit intovolta-cli:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #980
Info
inventory::package_configsfunction reads all of the files in the package config directory and attempts to parse them as package configs..DS_Storeon macOS).volta listto fail, instead they should be ignored.Changes
package_configsto ignore both directories and any file that doesn't have a.jsonextension.Tested
volta listto fail.