Include VC++ Redistributable with installer#592
Merged
charlespierce merged 1 commit intovolta-cli:masterfrom Nov 8, 2019
Merged
Include VC++ Redistributable with installer#592charlespierce merged 1 commit intovolta-cli:masterfrom
charlespierce merged 1 commit intovolta-cli:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #587
Our Windows executable requires that the Visual C++ Runtime is available in order to execute. This is often the case, however in brand-new installs (or as noted in the issue, the Windows Sandbox), it isn't always already installed. Given that, we should provide the VC++ merge module to make the runtime available on systems where it isn't already provided.
Followed the instructions here: https://wixtoolset.org/documentation/manual/v3/howtos/redistributables_and_install_checks/install_vcredist.html to include the redistributable merge module, and based on testing by @pjking07 in the issue, it appears to resolve the problem and allow Volta to run on those systems.