Move pin suggestion CTA to the project version message#1848
Merged
rwjblue merged 1 commit intovolta-cli:mainfrom Aug 15, 2024
Merged
Move pin suggestion CTA to the project version message#1848rwjblue merged 1 commit intovolta-cli:mainfrom
rwjblue merged 1 commit intovolta-cli:mainfrom
Conversation
Currently, the call-to-action suggestion to use `volta pin` is printed as part of the "success" message on every call to `volta install`. However, that message is confusing when you aren't in a project. Additionally, it's only necessary if the current project itself has a pinned version of the tool. We actually already have a message sent after installing if the project has an overlapping version: a note that the local version is different. This message seems like the ideal place to have the CTA, so that it lets users know what they can do to update the local version in case that's what they intended.
rwjblue
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1847
Info
Currently, the call-to-action suggestion to use
volta pinis printed as part of the "success" message on every call tovolta install. However, that message is confusing when you aren't in a project. Additionally, it's only necessary if the current project itself has a pinned version of the tool.We actually already have a message sent after installing if the project has an overlapping version: a note that the local version is different. This message seems like the ideal place to have the CTA, so that it lets users know what they can do to update the local version in case that's what they intended.
Changes
volta pinCTA from theinfo_installedmessageinfo_project_versionmessage to include avolta pinCTAinfo_project_versionto include the information about the newly-installed version as well.#[inline]attributes.Tested
Screenshots
Outside of a package
Inside a package with no pinned version
Inside a package with a pinned version