Skip to content

Update 'zip' to the latest version#1833

Merged
chriskrycho merged 1 commit intovolta-cli:mainfrom
charlespierce:zip_upgrade
Aug 12, 2024
Merged

Update 'zip' to the latest version#1833
chriskrycho merged 1 commit intovolta-cli:mainfrom
charlespierce:zip_upgrade

Conversation

@charlespierce
Copy link
Copy Markdown
Contributor

Info

  • With the bump to our MSRV, we can now take advantage of the latest version of zip
  • Additionally, we can take advantage of ZipStreamReader, which is an implementation of a streamed Zip extractor. It's marked as unstable so the crate authors recommend that we pin to a specific zip version when using it.
  • The ZipStreamReader lets us greatly simplify the code for fetching & extracting a Zip file, making it much more analogous to the tarball code.

Changes

  • Updated the version of zip, keeping the same features enabled.
  • Altered the implementation of Zip to take advantage of ZipStreamReader

Tested

  • Ran Volta locally on Windows and verified that fetching a Node version still works as expected.

Copy link
Copy Markdown
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩👏🏼

@chriskrycho chriskrycho merged commit 013475d into volta-cli:main Aug 12, 2024
@charlespierce charlespierce deleted the zip_upgrade branch August 12, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants