feat: use zshenv over zshrc in setup#1657
Merged
chriskrycho merged 1 commit intovolta-cli:mainfrom Jan 23, 2024
Merged
Conversation
chriskrycho
requested changes
Jan 20, 2024
Contributor
chriskrycho
left a comment
There was a problem hiding this comment.
So what we have here is good, and we will also need to update the install.sh.in script, which only checks for .zshrc to identify the current shell:
Lines 118 to 156 in aace0e5
If you can knock that out as well, we can get this merged!
a133339 to
37db506
Compare
37db506 to
ffcab2c
Compare
chriskrycho
approved these changes
Jan 23, 2024
Contributor
chriskrycho
left a comment
There was a problem hiding this comment.
Excellent! Much obliged!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1537
@chriskrycho