Update uninstall command's help text with examples of what can actually be uninstalled#1628
Merged
chriskrycho merged 4 commits intovolta-cli:mainfrom Jan 1, 2024
Merged
Conversation
dd3b0c1 to
f7633af
Compare
node and npm from uninstall command's help textuninstall command's help text with examples of what can actually be uninstalled
charlespierce
approved these changes
Dec 30, 2023
Contributor
charlespierce
left a comment
There was a problem hiding this comment.
LGTM! Thanks for taking this on!
At the time of writing this, uninstalling this tool is not supported: ``` ➜ volta uninstall node error: Uninstalling node is not supported yet. ``` Resolves volta-cli#1563
At the time of writing this, uninstalling this tool is not supported: ``` ➜ volta uninstall npm error: Uninstalling npm is not supported yet. ``` Resolves volta-cli#1563
At the time of writing this, uninstalling this tool is not supported: ``` ➜ volta uninstall yarn error: Uninstalling yarn is not supported yet. ```
With examples of what can actually be uninstalled.
f7633af to
97a09a6
Compare
Contributor
Author
|
Rebased and green again @charlespierce . |
Contributor
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this comment from @chriskrycho:
#1563 (comment)
Resolves #1563