Merged
Conversation
chriskrycho
requested changes
Dec 19, 2023
Contributor
chriskrycho
left a comment
There was a problem hiding this comment.
Thanks! Needs a small tweak to work as suggested in #1311, suggested as a revision.
crates/volta-core/src/tool/mod.rs
Outdated
| #[inline] | ||
| fn info_installed<T: Display + Sized>(tool: T) { | ||
| info!("{} installed and set {} as default", success_prefix(), tool); | ||
| info!("{} installed and set {} as default\n{} to use {tool} in this project run `volta pin {too; |
Contributor
There was a problem hiding this comment.
Looks like this is missing some of the necessary bits to actually present the right message here!
Suggested change
| info!("{} installed and set {} as default\n{} to use {tool} in this project run `volta pin {too; | |
| info!("{} installed and set {} as default", success_prefix(), tool); | |
| info!("{} to use {} in this project run `volta pin {}`, success_prefix(), tool); |
chriskrycho
approved these changes
Dec 29, 2023
Contributor
chriskrycho
left a comment
There was a problem hiding this comment.
Thanks! I've kicked off CI (which should pass) and we can get this merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1311