Remove the feature flag to fully enable Yarn3#1305
Merged
charlespierce merged 1 commit intovolta-cli:mainfrom Sep 16, 2022
Merged
Remove the feature flag to fully enable Yarn3#1305charlespierce merged 1 commit intovolta-cli:mainfrom
charlespierce merged 1 commit intovolta-cli:mainfrom
Conversation
|
Just as a feedback: I instantly had to pin yarn to v1 in all my scripts that use volta, tried yarn v3 (since it was now installed by default with volta install yarn) and it broke in the very first repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
VOLTA_FEATURE_YARN_3feature flag, so that Yarn3 is fully supported.Yarn3 Support (view)
I slightly modified some of the logic, because we are checking the
@yarnpkg/cli-distregistry first for Yarn3, before theyarnregistry for Yarn1, so that errors with Yarn3 don't impact Yarn1.