fix(cli): upload local files for dockerized localhost servers#961
Merged
fix(cli): upload local files for dockerized localhost servers#961
Conversation
Stop guessing shared filesystem access from localhost URLs and always upload client-visible local files before calling add-resource, add-skill, and import-ovpack.
zhoujh01
approved these changes
Mar 25, 2026
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix localhost file uploads for Dockerized OpenViking servers.
The CLI no longer assumes that
localhostor127.0.0.1means the server shares the caller filesystem, so local files are uploaded beforeadd-resource,add-skill, andimport-ovpackrequests.Background:
A common deployment pattern is running OpenViking server inside Docker while exposing it to the host as
http://localhost:<port>. In that setup, the CLI runs on the host, but the server process runs inside the container and cannot read host filesystem paths such as./SKILL.md. The old localhost heuristic treated this as a shared-filesystem deployment, skipped temp upload, and sent host paths directly to the containerized server.Related Issue
Fixes #959
Type of Change
Changes Made
.ovpackimports.add_skillregression test.Testing
Ran locally:
python -m pytest -o addopts='' tests/client/test_http_client_local_upload.py -qcargo check -p ov_cliNot run locally:
python -m pytest -o addopts='' tests/server/test_http_client_sdk.py -qcurrently fails in this environment becauseargon2is not installed.Checklist
Screenshots (if applicable)
N/A
Additional Notes
This specifically fixes host-CLI to Docker-server localhost deployments where host paths are not visible inside the container.