Fix HTTPX recognition issue with SOCKS5 proxy causing OpenViking crash#957
Merged
Mijamind719 merged 2 commits intovolcengine:mainfrom Mar 25, 2026
Merged
Conversation
|
wushijian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jcp0578
approved these changes
Mar 25, 2026
examples/openclaw-plugin/index.ts
Outdated
| const { ALL_PROXY, all_proxy, HTTP_PROXY, http_proxy, HTTPS_PROXY, https_proxy, ...filteredEnv } = process.env; | ||
| const env = { | ||
| ...process.env, | ||
| ...filteredEnv.env, |
Contributor
There was a problem hiding this comment.
Should this be ...filteredEnv instead of ...filteredEnv.env?
Contributor
Author
There was a problem hiding this comment.
yes,I fix it! sorry about that, commit twice
Mijamind719
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复系统代理如果使用socks5://开头会导致httpx库无法识别，引起openviking崩溃的问题，在插件的index.ts排除了环境变量中all_proxy/https_proxy等
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes