fix(config): validate ov.conf and ovcli.conf strictly#904
Merged
Conversation
Reject unknown ov.conf and ovcli.conf fields with friendly suggestions, and fail fast during server startup instead of silently ignoring typos. Co-Authored-By: Claude Opus 4.6
|
Failed to generate code suggestions for PR |
zhoujh01
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tighten config validation across
ov.confandovcli.confso unknown fields fail fast with readable error messages instead of being silently ignored. This also prevalidates the full config duringopenviking-server --config ...startup and consolidates shared validation/error-formatting helpers into one utility module.Related Issue
Fixes #855
Related prior PRs: #856, #881
Type of Change
Changes Made
server,parser, top-levelov.conf, andovcli.confreject unknown fields with explicit error paths instead of silently ignoring themopenviking-server --config ...startup and added regression tests for friendly error messages and config precedence behaviorTesting
Checklist
Screenshots (if applicable)
N/A
Additional Notes
ovcli.confnow also supports filling in missing auth/context fields even whenurlis passed explicitly, while keeping explicit arguments higher priority than config values.env OPENVIKING_CONFIG_FILE=/tmp/codex-no-config.json .venv/bin/python -m pytest tests/client/test_http_client_config.py tests/test_config_loader.py tests/test_server_config_loader.py tests/parse/test_markdown_char_limit.py -q