docs(process_lock): clarify Windows error handling for _is_pid_alive#849
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 22, 2026
Merged
Conversation
Update the comment in _is_pid_alive() to document additional Windows error codes that can be raised by os.kill(pid, 0) for stale or invalid PIDs. The previous comment only mentioned WinError 87, but users have reported WinError 11 (ERROR_BAD_FORMAT) as well. This change ensures the documentation accurately reflects the various Windows errors that can occur, helping future maintainers understand why the broad OSError catch is necessary. Related to volcengine#842
|
|
|
Failed to generate code suggestions for PR |
qin-ctx
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the comment in
_is_pid_alive()to document additional Windows error codes that can be raised byos.kill(pid, 0)for stale or invalid PIDs. The previous comment only mentioned WinError 87, but users have reported WinError 11 (ERROR_BAD_FORMAT) as well in issue #842.Changes
Why
This documentation improvement helps future maintainers understand why the broad OSError catch is necessary and prevents confusion when different Windows error codes are encountered.
Related Issue
Related to #842