fix(server): handle CancelledError during shutdown paths#848
Merged
ZaynJarvis merged 2 commits intomainfrom Mar 25, 2026
Merged
fix(server): handle CancelledError during shutdown paths#848ZaynJarvis merged 2 commits intomainfrom
ZaynJarvis merged 2 commits intomainfrom
Conversation
|
Failed to generate code suggestions for PR |
MaojiaSheng
approved these changes
Mar 25, 2026
…tracking to commit_async Remove router-level _background_commit_tracked since session.commit_async() already manages background task creation and returns a task_id. Drop the test that relied on the removed router-level cancellation handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous issue is Exception doesn't catch asyncio.CancelledError. so when asyncio.CancelledError happens, server crash.
Summary
asyncio.CancelledErrorexplicitly in shutdown-sensitive server pathsTesting