Skip to content

fix(helm): switch to volcengine defaults and add missing config fields#822

Merged
zhoujh01 merged 1 commit intomainfrom
fix/helm-volcengine-defaults
Mar 20, 2026
Merged

fix(helm): switch to volcengine defaults and add missing config fields#822
zhoujh01 merged 1 commit intomainfrom
fix/helm-volcengine-defaults

Conversation

@qin-ctx
Copy link
Copy Markdown
Collaborator

@qin-ctx qin-ctx commented Mar 20, 2026

Description

PR #800 引入的 Helm chart 默认使用 OpenAI 模型、缺少 root_api_key 字段和关键 storage 配置段。本 PR 将默认模型切换为火山引擎 doubao 系列,补齐缺失配置,并添加安全防护。

Related Issue

Follow-up to #800

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • values.yaml: 添加 root_api_key: "" 到 server 配置;补齐 storage.vectordbstorage.agfs 配置段(local backend 默认值);embedding/vlm 切换为火山引擎 doubao 系列模型
  • deployment.yaml: 添加 replicaCount > 1 的 fail 校验,防止多副本共享 PVC 导致 RocksDB 写锁竞争
  • NOTES.txt: 当 root_api_key 未设置时输出警告提示
  • README.md: Quick Start/Custom Values 示例更新为火山引擎参数;Configuration 表格添加 root_api_key 条目

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

验证命令:

# 渲染模板 — 语法正确
helm template test deploy/helm/openviking

# root_api_key 出现在 ConfigMap 中
helm template test deploy/helm/openviking | grep root_api_key

# replicaCount > 1 正确报错
helm template test deploy/helm/openviking --set replicaCount=2

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

N/A

Additional Notes

🤖 Generated with Claude Code

The Helm chart shipped with OpenAI as the default model provider but
OpenViking is a volcengine project. Switch embedding/vlm defaults to
doubao series, add the required root_api_key field, add missing
storage.vectordb/agfs config sections, and guard against replicaCount>1
which causes RocksDB lock contention on a single PVC.
@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

@zhoujh01 zhoujh01 merged commit b4127b3 into main Mar 20, 2026
6 checks passed
@zhoujh01 zhoujh01 deleted the fix/helm-volcengine-defaults branch March 20, 2026 11:45
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants