fix: expand tilde (~) in storage workspace paths#725
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Mar 18, 2026
Merged
Conversation
- Fix storage config to properly expand ~ to home directory - Add expanduser() before resolve() in storage_config.py and open_viking_config.py - Resolves issue where workspace: "~/.openviking/data" was treated as literal path - Ensures consistent behavior with other OpenViking config file resolution
qin-ctx
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where tilde expansion (~) doesn't work properly in the ov.conf storage workspace configuration.
Problem:
When configuring storage workspace as "
/.openviking/data" in ov.conf, the path was treated literally instead of expanding ~ to the user's home directory. This caused the application to create directories named "" instead of using the actual home directory.Root Cause:
The storage configuration code was using Path(workspace).resolve() without first calling expanduser() to handle the ~ character.
Solution:
Files Changed:
Testing:
The fix ensures that workspace paths like "~/.openviking/data" are properly expanded to "/Users/username/.openviking/data" before being resolved and used.